Add listing to stow storage apis #5674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugra Gedik <[email protected]>
* Refactor panic handling to middleware Signed-off-by: Jason Parraga <[email protected]> * Remove registration of old panicCounter Signed-off-by: Jason Parraga <[email protected]> * Add test coverage Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* TEST build Signed-off-by: Future-Outlier <[email protected]> * remove emphasize-lines Signed-off-by: Future-Outlier <[email protected]> * test build Signed-off-by: Future-Outlier <[email protected]> * revert Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…teorg#5612) * FlytePropeller Compiler Avoid Crash when Type not found Signed-off-by: Future-Outlier <[email protected]> * Update pingsu's error message advices Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> * fix lint Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: pingsutw <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
…#5623) Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
* first version Signed-off-by: Future-Outlier <[email protected]> * update Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: ddl-rliu <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* add send arg Signed-off-by: Yee Hing Tong <[email protected]> * Add acction to remove cache in gh runner Signed-off-by: Eduardo Apolinario <[email protected]> * Use correct checked out path Signed-off-by: Eduardo Apolinario <[email protected]> * Path in strings Signed-off-by: Eduardo Apolinario <[email protected]> * Checkout repo in root Signed-off-by: Eduardo Apolinario <[email protected]> * Use the correct path to new action Signed-off-by: Eduardo Apolinario <[email protected]> * Do not use gh var in path to clear-action-cache Signed-off-by: Eduardo Apolinario <[email protected]> * Remove wrong invocation of clear-action-cache Signed-off-by: Eduardo Apolinario <[email protected]> * GITHUB_WORKSPACE is implicit in the checkout action Signed-off-by: Eduardo Apolinario <[email protected]> * Refer to local `flyte` directory Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Andrew Dye <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…g#5635) * Make flyteidl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> * Make flytectl releases go through a manual gh workflow Signed-off-by: Eduardo Apolinario <[email protected]> * Rewrite the documentation for `version` and clarify wording in RELEASE.md Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* fix CHANGELOG-v0.2.0.md Signed-off-by: Christina <[email protected]> * fix CHANGELOG-v1.0.2-b1.md Signed-off-by: Christina <[email protected]> * fix CHANGELOG-v1.1.0.md Signed-off-by: Christina <[email protected]> * fix CHANGELOG-v1.3.0.md Signed-off-by: Christina <[email protected]> --------- Signed-off-by: Christina <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
* Fetch all tags in flyteidl-release.yml Signed-off-by: Eduardo Apolinario <[email protected]> * Fix sed expression for npm job Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…g#5545) * update Signed-off-by: Desi Hsu <[email protected]> * dco Signed-off-by: Desi Hsu <[email protected]> * dco Signed-off-by: Desi Hsu <[email protected]> * typo Signed-off-by: Desi Hsu <[email protected]> --------- Signed-off-by: Desi Hsu <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
flyteorg#5648) Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
flyteorg#5649) * Don't error when attempting to trigger schedules for inactive projects Signed-off-by: Katrina Rogan <[email protected]> * regen Signed-off-by: Katrina Rogan <[email protected]> --------- Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
….gedik/multi_pod_task_failure_handling_env
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5674 +/- ##
=======================================
Coverage 36.21% 36.22%
=======================================
Files 1303 1303
Lines 109568 109644 +76
=======================================
+ Hits 39683 39715 +32
- Misses 65765 65805 +40
- Partials 4120 4124 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* More concise definition of launchplan Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* save values Signed-off-by: Yee Hing Tong <[email protected]> * move things up Signed-off-by: Yee Hing Tong <[email protected]> * tests Signed-off-by: Yee Hing Tong <[email protected]> * unit test Signed-off-by: Yee Hing Tong <[email protected]> * imports for client test Signed-off-by: Yee Hing Tong <[email protected]> * more test Signed-off-by: Yee Hing Tong <[email protected]> * don't test admin connection Signed-off-by: Yee Hing Tong <[email protected]> * disable client for config Signed-off-by: Yee Hing Tong <[email protected]> * make generate Signed-off-by: Yee Hing Tong <[email protected]> * hide behind a once Signed-off-by: Yee Hing Tong <[email protected]> * typo Signed-off-by: Yee Hing Tong <[email protected]> * reset client builder test Signed-off-by: Yee Hing Tong <[email protected]> * reset client test Signed-off-by: Yee Hing Tong <[email protected]> * revert propeller Signed-off-by: Yee Hing Tong <[email protected]> * delay invocation even further Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* Update Flyte Components Signed-off-by: Flyte-Bot <[email protected]> * Add changelog and bump version in conf.py Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eapolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* Update Flyte Components Signed-off-by: Flyte-Bot <[email protected]> * Bump version in conf.py and add changelog Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Flyte-Bot <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eapolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…5704) * Do not emit execution id label by default in single binary Signed-off-by: Eduardo Apolinario <[email protected]> * Update flytestdlib/contextutils/context.go Co-authored-by: Thomas J. Fan <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: Thomas J. Fan <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…lyteorg#5705) Signed-off-by: Bugra Gedik <[email protected]>
* wip Signed-off-by: Kevin Su <[email protected]> * wip Signed-off-by: Kevin Su <[email protected]> * wip Signed-off-by: Kevin Su <[email protected]> * update tests Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * address comment Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * fix ci Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* add echo tasks Signed-off-by: Future-Outlier <[email protected]> * update nikki's advice Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: nikki everett <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: nikki everett <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: wayner0628 <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…ent (flyteorg#5709) Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: wayner0628 <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* Update helm/docs per changes in supported task discovery Signed-off-by: Jason Parraga <[email protected]> * Cleanup flyte-binary Signed-off-by: Jason Parraga <[email protected]> * fixes Signed-off-by: Jason Parraga <[email protected]> --------- Signed-off-by: Jason Parraga <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* Add Logging for Agent-Supported Task Types Signed-off-by: Future-Outlier <[email protected]> * use make(map[string]struct{}) Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* apply pod config to init containers Signed-off-by: Samhita Alla <[email protected]> * remove container Signed-off-by: Samhita Alla <[email protected]> * add test Signed-off-by: Samhita Alla <[email protected]> * Add bool to check init containers Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
* update langauge Signed-off-by: nikki everett <[email protected]> * Update docs/quickstart_guide.md Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Nikki Everett <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Nikki Everett <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
* feat: Use deterministic execution names in scheduler Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…tation (flyteorg#5731) Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
…lyteorg#5716) * Fix flytectl returning the oldest workflow when using --latest flag (flyteorg#5716) Signed-off-by: Rafael Raposo <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
- flyteorg#5032 updated builds to use Go 1.22 -- but in practice it looks like flytectl is being built with an outdated toolchain based on Go 1.22.0 instead of Go 1.22.5 or 1.22.6 (i.e. latest) See https://go.dev/doc/toolchain for further details For instance, flytectl v0.9.0 reports being built with Go 1.22.0 ❯ go version -m -v flytectl flytectl: go1.22.0 Ensure the proper Go environment for security reasons Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
…bgedik/flyte into bugra.gedik/add_listing_to_storage_apis
|
Messed up the DCO pretty bad, will create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Part of RFC https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend
Why are the changes needed?
Deterministic error propagation, see: https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend
What changes were proposed in this pull request?
Adding listing APIs
How was this patch tested?
Unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#5616
Docs link
N/A